CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

release: the dev-channel job never gates a release; desktop-dev retries the live dev latest.json on 5xx

Browse source
This commit is contained in:
CRTkafa 2026-10-26 11:05:08 +07:00
parent 1030cdff0c
commit 05d0e227a1
2 changed files with 11 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tools/desktop-dev.ts
View file

@ -62,10 +62,14 @@ export function pruneDev<T extends { tag_name: string }>(releases: T[], keep = K
}
async function liveDev(): Promise<string | null> {
const r = await fetch(`${DEV_URL}?t=${Date.now()}`, { signal: AbortSignal.timeout(20_000) }).catch(() => null);
if (!r || r.status === 404) return null;
if (!r.ok) throw new Error(`${DEV_URL}: HTTP ${r.status}`);
return ((await r.json()) as { version?: string }).version ?? null;
// a 5xx from the CDN / origin is often a blip: try a few times before giving up
for (let i = 0; ; i++) {
const r = await fetch(`${DEV_URL}?t=${Date.now()}`, { signal: AbortSignal.timeout(20_000) }).catch(() => null);
if (r?.status === 404) return null;
if (r?.ok) return ((await r.json()) as { version?: string }).version ?? null;
if (i >= 4) throw new Error(`${DEV_URL}: ${r ? `HTTP ${r.status}` : 'no answer'} after ${i + 1} tries`);
await new Promise(res => setTimeout(res, 5_000 * (i + 1)));
}
}
function commitDate(): Date {

5
tools/release-candidate.ts
View file

@ -95,8 +95,9 @@ export interface Task { id: number; name: string; run_number: number; workflow_i
/** The state of a commit from its ci.yml jobs (the newest run of that commit) and whether its record exists. Pure. */
export function taskState(tasks: Task[], sha: string, runUrl: (n: number) => string): Exclude<Status, { state: 'green' }> {
// the background test jobs (ci, acceptance) never gate a release (the owner's decision 2026-10-16): only the
// installer builds and the record count; tools/ci-status.ts reports the tests
const mine = tasks.filter(t => t.head_sha === sha && t.workflow_id === 'ci.yml' && !/^(ci|acceptance\b)/.test(t.name));
// installer builds and the record count; tools/ci-status.ts reports the tests. The dev job (the owner's dev update
// channel) never gates a release either: a hiccup publishing a dev build must not hold back npm.
const mine = tasks.filter(t => t.head_sha === sha && t.workflow_id === 'ci.yml' && !/^(ci|acceptance\b|dev$)/.test(t.name));
if (!mine.length) return { state: 'none' };
const latest = Math.max(...mine.map(t => t.run_number));
const jobs = mine.filter(t => t.run_number === latest);