CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

apple iap-submit: DEVELOPER_REJECTED IAP / subscription / group versions (left by a canceled submission) are submitted as they are, plan says 'add (developer rejected, re-submitted as is)', --new-version only for APPROVED / REJECTED, empty draft reused; fake ASC models cancel and re-add. play build / check: warn before Gradle when defaultConfig does not read -PversionCode / -PversionName, with the exact Groovy / Kotlin line (built with AGP 8.13); android.injected.version.code does not override bundleRelease; post-build versionCode mismatch is a hard stop. play-production-release plan: 'Do you want to restart your review?' dialog, Restart review is never-press. Pitfalls 31-33

Browse source
This commit is contained in:
CRTkafa 2026-10-12 11:32:05 +08:00
parent 41d2ffcc24
commit 0b1451800c
18 changed files with 399 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/web-assets.test.ts
View file

@ -215,6 +215,17 @@ describe('check', () => {
const withPre = project('check-pre', { build: { prebuild: 'npx cap sync' } });
expect(checkJson(sb(withPre, 'check', '--json')).warnings.join()).not.toContain('web assets');
});
test('warns when android/app/build.gradle does not read -PversionCode / -PversionName (literal or env var), with the line to use', () => {
const d = project('check-vc', { build: { prebuild: 'npx cap sync' } });
touch(d, 'android/app/build.gradle', "android {\n defaultConfig {\n versionCode System.getenv('VERSION_CODE') as Integer ?: 1\n versionName '1.0'\n }\n}\n");
const w = checkJson(sb(d, 'check', '--json')).warnings.filter(x => x.startsWith('play: android/app/build.gradle'));
expect(w).toHaveLength(2);
expect(w[0]).toContain('android/app/build.gradle:3: versionCode does not come from the project property versionCode');
expect(w[0]).toContain("versionCode((project.findProperty('versionCode') ?: 1) as Integer)");
expect(w[1]).toContain("versionName project.findProperty('versionName') ?: '1.0'");
touch(d, 'android/app/build.gradle', "android {\n defaultConfig {\n versionCode((project.findProperty('versionCode') ?: 1) as Integer)\n versionName project.findProperty('versionName') ?: '1.0'\n }\n}\n");
expect(checkJson(sb(d, 'check', '--json')).warnings.join()).not.toContain('build.gradle');
});
});
/** check --json prints its log lines first, then the result object. */