apple creative-assets: select Header and Search Results assets once processed (Prepare for Submission), not once approved: Apple reviews an asset only in a review submission, so 0.8.13 waited forever; upload and select in one run with a bounded processing wait; --add-for-review puts unreviewed assets into the draft review submission (never submits); --verify reads every slot back read-only (MCP apple_creative_assets_verify); a rejected file or one that failed processing twice is not re-uploaded, an archived copy is unarchived; fake commits library assets to PREPARE_FOR_SUBMISSION; pitfall 76 rewritten; apple-name check test only looks at name hints

skills/store-pitfalls/SKILL.md

@@ -913,15 +913,22 @@ that fails without the fix (see CONTRIBUTING.md).
   `screenshots-duo` note in check / validate. `tests/ppo.test.ts`.
 
 ## 76. Header and Search Results assets are not uploaded like screenshots
-- **Symptom:** a header or search results image was "uploaded" but the version page still says "Browse approved
-  assets to select a header asset", or a re-run uploaded the same file again.
+- **Symptom:** a header or search results image was "uploaded" but the version page shows no header, a run kept saying
+  "waiting for Apple's approval" for days, or a re-run uploaded the same file again.
 - **Cause:** these slots take assets from the app's Asset Library (`GET /v1/apps/{id}/assetLibrary`), not a set of
-  their own. Each asset is reviewed by Apple first; only an APPROVED asset can be selected (an
-  `appAssetLibraryPlacements` row with `PRODUCT_PAGE_HEADER_ASSET` or `APP_STORE_SEARCH_RESULTS_ASSET` and the version
-  localization). Library assets carry no `sourceFileChecksum`, and the write-ups' name for the search slot is the
-  API's `APP_STORE_SEARCH_RESULTS_ASSET` (`SEARCH_RESULTS_ADS_ASSET` is the Apple Ads one).
-- **Do:** `storebound apple creative-assets`: it keeps the file's MD5 in `referenceName` ("storebound <md5>"), reuses
-  a library asset with the same MD5, selects only approved ones and says "waiting for Apple's approval" otherwise.
-  Uploading and selecting are normal steps, not owner buttons; the version's Submit for Review stays the owner's.
-- **Guard:** `cli/apple/creative-assets.ts`, `tests/creative-assets.test.ts` (fake App Store Connect: dry run, upload,
-  waiting, select, replace on a changed file, nothing on the same file).
+  their own: a slot is an `appAssetLibraryPlacements` row (`PRODUCT_PAGE_HEADER_ASSET` or
+  `APP_STORE_SEARCH_RESULTS_ASSET`, the version localization). An asset is reviewed only once it is in a review
+  submission (its own item, `reviewSubmissionItems` with `appAssetLibraryImage` / `appAssetLibraryVideo`; the console's
+  "Add for Review"). Apple's "App Store asset statuses": a processed asset is "Prepare for Submission" and can already
+  be selected for a version. So an earlier storebound that selected only APPROVED assets waited forever: nothing ever
+  sent the asset to review. Library assets carry no `sourceFileChecksum`, a rejected asset stays rejected (uploading
+  the same bytes again only adds a copy), and the search slot is the API's `APP_STORE_SEARCH_RESULTS_ASSET`
+  (`SEARCH_RESULTS_ADS_ASSET` is the Apple Ads one).
+- **Do:** `storebound apple creative-assets`: MD5 in `referenceName` ("storebound <md5>"), reuse (or unarchive) a library
+  asset with the same MD5, select it once processed, never re-upload a rejected file or one that failed processing
+  twice. Then `--add-for-review` puts the unreviewed assets into the draft submission (with the first version, or alone
+  once the app has an approved version) and `--verify` reads every slot back. Uploading, selecting and adding to the
+  draft are normal steps, not owner buttons; Submit for Review stays the owner's.
+- **Guard:** `cli/apple/creative-assets.ts` (`classify`, `pickAsset`, `processingTiming`), `tests/creative-assets.test.ts`
+  (fake App Store Connect: upload and select in one run, still processing, rejected / archived files, add-for-review
+  without submitting, verify read-only); the fake commits library assets to PREPARE_FOR_SUBMISSION, as Apple does.

skills/store-screenshots/SKILL.md

@@ -207,11 +207,19 @@ Screenshots". Optional: without these assets the App Store uses in-app events, a
   play muted. `apple.creativeAssets.header: false` / `search: false` skips a slot.
 - **Not rendered by `shots render`**: the scene templates are portrait device shots; make the wide art yourself (or from
   the feature graphic artwork at the larger size) and drop it in.
-- **Upload:** `storebound apple creative-assets --dry`, then without `--dry`. Files go into the app's Asset Library
-  (API: `appAssetLibraryImages` / `appAssetLibraryVideos`, category `CREATIVE_ASSETS`); Apple reviews each asset, and
-  only an approved one is selected for the slot (`appAssetLibraryPlacements`, `PRODUCT_PAGE_HEADER_ASSET` /
-  `APP_STORE_SEARCH_RESULTS_ASSET`). Until then the run says "waiting for Apple's approval": re-run later. Same file
-  (MD5) = nothing sent. MCP: `apple_creative_assets` (dry by default).
+- **Upload and select:** `storebound apple creative-assets --dry`, then without `--dry`. Files go into the app's Asset
+  Library (API: `appAssetLibraryImages` / `appAssetLibraryVideos`, category `CREATIVE_ASSETS`), and once processed
+  ("Prepare for Submission", a bounded wait of 2 minutes with a heartbeat) the run selects them for the slots of the
+  editable version (`appAssetLibraryPlacements`, `PRODUCT_PAGE_HEADER_ASSET` / `APP_STORE_SEARCH_RESULTS_ASSET`), as the
+  console's Browse Assets > Save does. Approval is not needed first. Same file (MD5) = nothing sent; an archived copy is
+  unarchived; a file App Review rejected is never uploaded again (change the file). MCP: `apple_creative_assets` (dry by
+  default).
+- **Review:** an asset is reviewed only once it is in a review submission (its own item, `appAssetLibraryImage` /
+  `appAssetLibraryVideo`; the console's "Add for Review"). `--add-for-review` adds the selected, unreviewed assets to the
+  app's draft submission, once: before the first approved version it is the same submission as that version, later
+  they can go alone. Pressing Submit for Review stays the owner's.
+- **Verify:** `storebound apple creative-assets --verify` (MCP `apple_creative_assets_verify`) is read-only: every slot
+  of the editable version (else the live one) shows the local file, with its review state; exit 1 when one differs.
 - **Checks:** `storebound check` and `validate` print an info note when no locale has one.
 - **Play:** no such slot. The feature graphic (1024 x 500, `play images`) and the promo video (YouTube URL) are the
   closest equivalents.