CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

doctor: build dependencies (JDK with the version the project needs, Android SDK command-line tools, CocoaPods, Node, Bun, bundletool), too-old status, doctor --install <tool> --yes runs the package-manager command (never sudo); desktop Dependencies shows too old; gen-flags works on Windows paths

Browse source
This commit is contained in:
CRTkafa 2026-10-22 02:21:26 +08:00
parent a8a889fb35
commit 2598c4953a
10 changed files with 137 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/deps.test.ts Normal file
View file

@ -0,0 +1,36 @@
// Build dependencies: the JDK the project needs, version parsing, and doctor --install planning.
import { describe, expect, test } from 'bun:test';
import { mkdirSync, mkdtempSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { installPlan, type DoctorResult } from '../cli/doctor';
import { installCommands, majorOf, parseVersion, requiredJdk } from '../cli/lib/tools';
function project(files: Record<string, string>): string {
const dir = mkdtempSync(join(tmpdir(), 'sb-deps-'));
for (const [p, text] of Object.entries(files)) { mkdirSync(join(dir, p, '..'), { recursive: true }); writeFileSync(join(dir, p), text); }
return dir;
}
describe('build dependencies', () => {
test('JDK version from java -version and majors', () => {
expect(parseVersion('openjdk version "17.0.9" 2023-10-17')).toBe('17.0.9');
expect(parseVersion('java version "1.8.0_392"')).toBe('1.8.0_392');
expect(majorOf('17.0.9')).toBe(17);
expect(majorOf('1.8.0_392')).toBe(8);
});
test('the JDK a project needs: AGP minimum, jvmToolchain wins when higher', () => {
expect(requiredJdk(project({ 'android/build.gradle': "classpath 'com.android.tools.build:gradle:8.7.2'" }))).toBe('17');
expect(requiredJdk(project({ 'android/build.gradle': "classpath 'com.android.tools.build:gradle:7.4.2'" }))).toBe('11');
expect(requiredJdk(project({ 'android/gradle/libs.versions.toml': 'agp = "8.5.0"', 'android/app/build.gradle.kts': 'kotlin { jvmToolchain(21) }' }))).toBe('21');
expect(requiredJdk(project({ 'package.json': '{}' }))).toBeNull();
});
test('install commands per OS; doctor --install runs only package-manager commands, never sudo', () => {
expect(installCommands('java', 'win32')[0]).toBe('winget install --id EclipseAdoptium.Temurin.17.JDK');
expect(installCommands('sdkmanager', 'darwin')[0]).toBe('brew install --cask android-commandlinetools');
const r = { tools: [{ id: 'java', name: 'JDK (Java)', found: false, version: null, path: null, source: null, usedFor: '', install: [], url: null, status: 'missing' }] } as unknown as DoctorResult;
expect(installPlan(r, 'java', 'win32')).toMatchObject({ command: 'winget install --id EclipseAdoptium.Temurin.17.JDK', runnable: true });
expect(installPlan(r, 'java', 'linux').runnable).toBe(false);
expect(() => installPlan(r, 'nope', 'win32')).toThrow('no tool "nope"');
});
});