apple submit --yes submits a draft prepared with --no-submit that already holds the version and items (was 'nothing to submit'); iap-submit the same for a draft holding the asked-for items; test, pitfall 90, CHANGELOG

This commit is contained in:
CRTkafa 2026-10-21 11:19:50 +07:00
parent 0d1926f7d7
commit 4d70be3404
6 changed files with 52 additions and 6 deletions

View file

@ -1100,3 +1100,16 @@ that fails without the fix (see CONTRIBUTING.md).
- **Guard:** `readGcSwitch` / `gcSwitchPlan` / `ensureGcSwitch` / `gameCenterInUse` in `cli/apple/game-center.ts`,
`gameServicesFindings` (codes game-center.detail, game-center.version), the fake store's `gameCenterBuild` 409 and
`tests/game-services.test.ts`.
## 90. The second step of `apple submit --no-submit` said "nothing to submit"
- **Symptom:** `apple submit --build N --version X --yes` after `apple submit --no-submit --yes` prepared the draft
printed the plan (every item "in it already", last row "submit PATCH submitted: true · owner step (--yes)"),
logged "not added <iap>: already in the draft submission" for each item and ended with "nothing to submit"; the
draft stayed READY_FOR_REVIEW and was never sent.
- **Cause:** the submit ran only when the run added items or the submission was back from App Review
(UNRESOLVED_ISSUES). A draft that already held everything counted as nothing to do.
- **Do:** update storebound and run the same `--yes` again: the prepared draft is submitted as it is (with the
"not ready yet" retry). A plan that ends with a submit row and a run that ends with "nothing to submit" is a bug:
check `apple status` for the draft's state before re-running anything else.
- **Guard:** `willSubmit` in `cli/lib/review-submit.ts` (a non-empty READY_FOR_REVIEW draft that holds the named app
version, or for `iap-submit` an asked-for item, is submitted); `tests/resubmit.test.ts`.