CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

privacy manifest discovery skips build-output and copy folders (hidden dirs like .native-build, build, DerivedData, node_modules, dist, Products, built .app / .xcarchive) in scan, check and privacy-manifest: a stale .native-build copy was checked instead of the real ios/ manifest; test

Browse source
This commit is contained in:
CRTkafa 2026-10-14 13:14:49 +08:00
parent 7219ded3e8
commit 73db689386
4 changed files with 49 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

34
tests/privacy-build-copy.test.ts Normal file
View file

@ -0,0 +1,34 @@
// A stale build-output copy of the app's PrivacyInfo.xcprivacy (seen live: .native-build/apps/native/ios/App/App/)
// must not be read as the app's own manifest by check / scan / privacy-manifest. Placeholder data only.
import { afterAll, expect, test } from 'bun:test';
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { isBuildCopyPath } from '../cli/lib/privacy-manifest';
import { detectProject } from '../cli/lib/scan/project';
const tmp = mkdtempSync(join(tmpdir(), 'sb-pm-copy-'));
afterAll(() => rmSync(tmp, { recursive: true, force: true }));
const manifest = (collected: boolean) => `<?xml version="1.0" encoding="UTF-8"?>
<plist version="1.0"><dict><key>NSPrivacyTracking</key><false/><key>NSPrivacyCollectedDataTypes</key><array>${collected
? '<dict><key>NSPrivacyCollectedDataType</key><string>NSPrivacyCollectedDataTypeCrashData</string><key>NSPrivacyCollectedDataTypeLinked</key><false/><key>NSPrivacyCollectedDataTypeTracking</key><false/><key>NSPrivacyCollectedDataTypePurposes</key><array><string>NSPrivacyCollectedDataTypePurposeAppFunctionality</string></array></dict>'
: ''}</array><key>NSPrivacyAccessedAPITypes</key><array/></dict></plist>`;
test('isBuildCopyPath: hidden, build and copy folders are skipped, the real ios tree is not', () => {
for (const p of ['.native-build/apps/native/ios/App/App/PrivacyInfo.xcprivacy', 'ios/build/App.app/PrivacyInfo.xcprivacy',
'DerivedData/x/PrivacyInfo.xcprivacy', 'dist/ios/PrivacyInfo.xcprivacy', '.output/PrivacyInfo.xcprivacy', 'node_modules/a/PrivacyInfo.xcprivacy'])
expect(isBuildCopyPath(p)).toBe(true);
for (const p of ['apps/native/ios/App/App/PrivacyInfo.xcprivacy', 'ios/App/App/PrivacyInfo.xcprivacy', 'PrivacyInfo.xcprivacy'])
expect(isBuildCopyPath(p)).toBe(false);
});
test('scan facts: the real manifest is found, the stale .native-build copy is not', () => {
const real = join(tmp, 'apps/native/ios/App/App');
const copy = join(tmp, '.native-build/apps/native/ios/App/App');
mkdirSync(real, { recursive: true });
mkdirSync(copy, { recursive: true });
writeFileSync(join(real, 'PrivacyInfo.xcprivacy'), manifest(true));
writeFileSync(join(copy, 'PrivacyInfo.xcprivacy'), manifest(false));
expect(detectProject(tmp).privacyManifests.map(m => m.path)).toEqual(['apps/native/ios/App/App/PrivacyInfo.xcprivacy']);
});