CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

Reviews: a store read that failed everywhere is an error, not an empty fresh list; Reviews tab says Apple's API can lag and Play returns 7 days; pitfall 106

Browse source
This commit is contained in:
CRTkafa 2026-10-23 00:33:27 +08:00
parent 0e88e4293a
commit 75bf62e125
7 changed files with 50 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
cli/lib/reviews.ts
View file

@ -63,6 +63,19 @@ export function parsePlayReviews(resp: PlayReviewsResp): Review[] {
});
}
export interface StoreRead { store: 'apple' | 'play'; reviews?: Review[]; error?: string }
/**
* Combines the per-store reads of `reviews list`. A store that failed is reported (warning text per store) but does not
* hide the other one; when EVERY store that was asked failed it throws, so a broken key never reads as "0 reviews, all
* fine" (the desktop kept such an empty result as a fresh read and showed no new reviews).
*/
export function settleStoreReads(reads: StoreRead[]): { reviews: Review[]; errors: string[] } {
const errors = reads.filter(r => r.error !== undefined).map(r => `${r.store}: ${r.error}`);
if (reads.length && errors.length === reads.length) throw new Error(errors.join('; '));
return { reviews: reads.flatMap(r => r.reviews ?? []), errors };
}
/** Reviews newer than `sinceIso`, optional filters, newest first. */
export function filterReviews(rs: Review[], o: { since?: string; unanswered?: boolean; ratings?: number[] } = {}): Review[] {
return rs.filter(r => (!o.since || r.date >= o.since) && (!o.unanswered || !r.reply) && (!o.ratings?.length || o.ratings.includes(r.rating)))