CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

play: changesNotSentForReview goes only on edits.commit (validate answers 400 "Unknown name changesNotSentForReview: Cannot bind query parameter", found by a game on 220e9bb's real run): a refused commit is committed again with the parameter, a dry run's refused validate only says how the real run commits; the fake Play refuses the parameter on validate and a test asserts validate never gets it

Browse source
This commit is contained in:
CRTkafa 2026-10-16 05:53:18 +08:00
parent dcb553fd16
commit 8a84ab4089
6 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
skills/store-pitfalls/SKILL.md
View file

@ -842,7 +842,7 @@ that fails without the fix (see CONTRIBUTING.md).
- **Cause:** after a rejection (here production 1.0.0 (3), Broken Functionality), with other changes pending in the
Console or with managed publishing, Play no longer sends an API commit for review by itself. The edit is fine; only
the automatic send is refused. storebound <= 0.8.8 stopped there.
- **Do:** nothing by hand: storebound validates and commits the same edit again with changesNotSentForReview=true
- **Do:** nothing by hand: storebound commits the same edit again with changesNotSentForReview=true (only edits.commit binds it; validate answers 400 "Unknown name ... Cannot bind query parameter")
(`--not-sent-for-review` sets it from the start; MCP `not_sent_for_review`). A dry run says the real run will commit
that way. Then the owner presses **Send changes for review** in Publishing overview (storebound prints the deep link):
that button is the owner's, never press or automate it. The API has no read of "waiting for Send changes for