CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

play: changesNotSentForReview goes only on edits.commit (validate answers 400 "Unknown name changesNotSentForReview: Cannot bind query parameter", found by a game on 220e9bb's real run): a refused commit is committed again with the parameter, a dry run's refused validate only says how the real run commits; the fake Play refuses the parameter on validate and a test asserts validate never gets it

Browse source
This commit is contained in:
CRTkafa 2026-10-16 05:53:18 +08:00
parent dcb553fd16
commit 8a84ab4089
6 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/play-not-sent-for-review.test.ts
View file

@ -35,13 +35,14 @@ describe('Play refuses the automatic send for review', () => {
expect(isReviewRefused(new Error('POST /edits/e1:commit -> 400 {"error":{"message":"Version code 5 has already been used."}}'))).toBe(false);
});
test('real run: the commit is refused once, then the same edit is validated and committed with changesNotSentForReview=true', async () => {
test('real run: the commit is refused once, then the same edit is committed with changesNotSentForReview=true (validate never takes it)', async () => {
const p = project(BASE, { 'store/listing.md': LISTING });
s.play.refuseAutoReview = 1;
const r = await release(p);
expect(r.exit ?? 0).toBe(0);
expect(edits('commit')).toEqual(['edit-1:commit', 'edit-1:commit?changesNotSentForReview=true']);
expect(edits('validate')).toEqual(['edit-1:validate?changesNotSentForReview=true']);
expect(edits('validate').filter(v => v.includes('changesNotSentForReview'))).toEqual([]);
expect(s.play.validateWithNotSent).toBe(0);
expect(s.calls.filter(c => c.method === 'POST' && /\/edits$/.test(c.path))).toHaveLength(1); // one edit, never reopened
expect(s.play.committed).toEqual(['edit-1']);
expect(s.play.live.tracks.production).toBeDefined();
@ -53,12 +54,13 @@ describe('Play refuses the automatic send for review', () => {
expect(rec!.summary).toContain('production completed');
});
test('dry run: validate is refused once, validated again with the parameter, no commit, says how the real run commits', async () => {
test('dry run: validate is refused once, never sent the parameter, no commit, says how the real run commits', async () => {
const p = project(BASE, { 'store/listing.md': LISTING });
s.play.refuseAutoReview = 1;
const r = await release(p, ['--dry']);
expect(r.exit ?? 0).toBe(0);
expect(edits('validate')).toEqual(['edit-1:validate', 'edit-1:validate?changesNotSentForReview=true']);
expect(edits('validate')).toEqual(['edit-1:validate']);
expect(s.play.validateWithNotSent).toBe(0);
expect(edits('commit')).toEqual([]);
expect(s.play.committed).toEqual([]);
expect(s.play.edits.size).toBe(0);