merge origin/main (cross-store text checker); macOS platform pitfall renumbered to 79
This commit is contained in:
commit
9db7180eb9
35 changed files with 618 additions and 60 deletions
|
|
@ -36,6 +36,8 @@ import { playClient } from './play/client';
|
|||
import { listOneTimeProducts } from './play/products';
|
||||
import { creativeNote } from './shots/creative';
|
||||
import { creativeWaiting, localCreative } from './apple/creative-assets';
|
||||
import { fixFor, GUIDELINE, hitLine } from './lib/cross-store';
|
||||
import { listingFileMentions } from './lib/listing-mentions';
|
||||
|
||||
/** Profile facts for the checks: config + local credentials + public URL checks (no store API). */
|
||||
export async function collectProfile(loaded: Loaded): Promise<ProfileFacts> {
|
||||
|
|
@ -223,6 +225,11 @@ export async function run(ctx: Ctx): Promise<void> {
|
|||
try { findings.push(...playRules({ ...(await collectPlay(ctx)), renders: local?.play })); }
|
||||
catch (e) { findings.push({ store: 'play', level: 'blocker', code: 'api', msg: (e as Error).message.slice(0, 400) }, ...rendersFindings('play', local?.play)); }
|
||||
} else if (a.has('play')) warn('validate', 'no play section in the config');
|
||||
// other platforms named in a store's listing text (App Store 2.3.10, Play Metadata): blockers (pitfall 77)
|
||||
try {
|
||||
for (const h of listingFileMentions(ctx.loaded, { apple: (both || a.has('apple')) && !!config.apple, play: (both || a.has('play')) && !!config.play }))
|
||||
findings.push({ store: h.store, level: 'blocker', code: 'other-platforms', msg: `${GUIDELINE[h.store]}: ${hitLine(h)}`, fix: fixFor(h.store, h.field) });
|
||||
} catch (e) { warn('validate', `platform mentions: ${(e as Error).message}`); }
|
||||
// template compliance answers: the scan reports them; without the scan, here
|
||||
if (a.has('no-scan')) for (const msg of templateBlockers(config)) findings.push({ store: config.apple ? 'apple' : 'play', level: 'blocker', code: 'template-answers', msg });
|
||||
if (!a.has('no-scan')) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue