First in-app purchases left out of a review are caught (pitfall 70): firstProductGaps in validate / release plan (blocker) and the apple submit plan (refuses to leave a never-approved first product out); apple status (WARN + firstProductGaps in --json), release status and the desktop checks warn while a version waits for or is in review without it; iap-review says 'ready, not submitted yet' instead of 'complete'
This commit is contained in:
parent
1c35a625e1
commit
b830a99a5f
16 changed files with 288 additions and 18 deletions
|
|
@ -94,7 +94,7 @@ async function status(args: Args): Promise<void> {
|
|||
const read = await pool(list, concurrency, async t => ({ t, s: await readLive(t) }));
|
||||
if (args.has('json')) {
|
||||
printJson({ apps: read.map(({ t, s }) => ({
|
||||
app: t.name, folder: t.virtual ? null : t.dir, errors: [...t.problems, ...s.errors], storeErrors: s.storeErrors,
|
||||
app: t.name, folder: t.virtual ? null : t.dir, errors: [...t.problems, ...s.errors], warnings: s.warnings ?? [], storeErrors: s.storeErrors,
|
||||
trains: trainsOf(s, all).map(({ which, train }) => ({ which, version: train.version, ios: train.ios, android: train.android,
|
||||
lanes: { ios: laneOf('ios', train.ios), android: laneOf('android', train.android) } })),
|
||||
})), at: new Date().toISOString() });
|
||||
|
|
@ -105,6 +105,7 @@ async function status(args: Args): Promise<void> {
|
|||
const unread = Object.keys(s.storeErrors).length > 0;
|
||||
if (!trains.length) rows.push([t.name, '', '', s.errors[0] ? `error: ${s.errors[0]}` : unread ? 'not read (see the warnings)' : 'no version on either store yet', '']);
|
||||
for (const { which, train } of trains) rows.push([t.name, train.version, which === 'other' ? '' : which, cell('ios', train, s), cell('android', train, s)]);
|
||||
for (const w of s.warnings ?? []) warn('release', `${t.name}: ${w}`);
|
||||
for (const p of [...t.problems, ...s.errors.slice(trains.length ? 0 : 1), ...Object.entries(s.storeErrors).map(([k, v]) => `${k}: ${v}`)]) warn('release', `${t.name}: ${p}`);
|
||||
}
|
||||
console.log(textTable(['app', 'version', 'train', 'App Store', 'Google Play'], rows));
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue