Merge remote-tracking branch 'origin/main' into fast-ci

This commit is contained in:
CRTkafa 2026-10-12 05:16:52 +08:00
commit c51b689070
7 changed files with 244 additions and 85 deletions

View file

@ -168,6 +168,8 @@ export interface OpenOpts {
hosts?: string[]; hosts?: string[];
headless?: boolean; headless?: boolean;
platform?: string; platform?: string;
/** Tests: Playwright's launch timeout for modes (b) and (c) (default: Playwright's 30 s). */
launchTimeoutMs?: number;
say: (m: string) => void; say: (m: string) => void;
} }
@ -233,7 +235,7 @@ export async function openConsoleBrowser(root: string, o: OpenOpts): Promise<Con
copy = await copySession(chromeDir, { ...(o.chromeProfile ? { profile: o.chromeProfile } : {}), ...(o.hosts ? { hosts: o.hosts } : {}) }); copy = await copySession(chromeDir, { ...(o.chromeProfile ? { profile: o.chromeProfile } : {}), ...(o.hosts ? { hosts: o.hosts } : {}) });
const c = await chromiumFor(root); const c = await chromiumFor(root);
const context = await c.launchPersistentContext(copy.dir, { const context = await c.launchPersistentContext(copy.dir, {
channel: 'chrome', headless: o.headless ?? false, viewport: null, args: KEEP_SESSION_ARGS, channel: 'chrome', headless: o.headless ?? false, viewport: null, args: KEEP_SESSION_ARGS, ...(o.launchTimeoutMs ? { timeout: o.launchTimeoutMs } : {}),
// Playwright's mock keychain would hide Chrome's own key, and the cookies could not be read // Playwright's mock keychain would hide Chrome's own key, and the cookies could not be read
ignoreDefaultArgs: ['--use-mock-keychain', '--password-store=basic'], ignoreDefaultArgs: ['--use-mock-keychain', '--password-store=basic'],
}); });
@ -251,7 +253,7 @@ export async function openConsoleBrowser(root: string, o: OpenOpts): Promise<Con
} }
// (c) storebound's persistent profile, the owner signs in there // (c) storebound's persistent profile, the owner signs in there
mkdirSync(o.profileDir, { recursive: true }); mkdirSync(o.profileDir, { recursive: true });
const context = await launchPersistent(root, o.profileDir, { headless: o.headless ?? false, viewport: null, args: KEEP_SESSION_ARGS }); const context = await launchPersistent(root, o.profileDir, { headless: o.headless ?? false, viewport: null, args: KEEP_SESSION_ARGS, ...(o.launchTimeoutMs ? { timeout: o.launchTimeoutMs } : {}) });
o.say(`browser: storebound's own profile (${o.profileDir}); sign in there once, it is kept for the next run`); o.say(`browser: storebound's own profile (${o.profileDir}); sign in there once, it is kept for the next run`);
const page = await ownTab(context); const page = await ownTab(context);
return wrapContext('profile', context, page, () => { /* kept on purpose */ }); return wrapContext('profile', context, page, () => { /* kept on purpose */ });

View file

@ -116,7 +116,10 @@ const COMPETITORS = ['instagram', 'tiktok', 'whatsapp', 'facebook', 'snapchat',
'amazon', 'chatgpt', 'openai', 'minecraft', 'roblox', 'fortnite', 'pubg', 'candy crush', 'clash of clans', 'pokemon', 'pokémon', 'among us', 'subway surfers', 'temple run', 'amazon', 'chatgpt', 'openai', 'minecraft', 'roblox', 'fortnite', 'pubg', 'candy crush', 'clash of clans', 'pokemon', 'pokémon', 'among us', 'subway surfers', 'temple run',
'angry birds', 'tetris', 'wordle', 'duolingo', 'zoom', 'gmail', 'google maps', 'waze', 'shazam', 'tinder', 'notion', 'evernote', 'photoshop', 'canva', 'capcut', 'iphone', 'ipad', 'apple']; 'angry birds', 'tetris', 'wordle', 'duolingo', 'zoom', 'gmail', 'google maps', 'waze', 'shazam', 'tinder', 'notion', 'evernote', 'photoshop', 'canva', 'capcut', 'iphone', 'ipad', 'apple'];
const OTHER_PLATFORMS = /\b(Android|Google Play|Play Store|Galaxy Store|AppGallery|Huawei|Windows Phone|BlackBerry|Amazon Appstore)\b/; const OTHER_PLATFORMS = /\b(Android|Google Play|Play Store|Galaxy Store|AppGallery|Huawei|Windows Phone|BlackBerry|Amazon Appstore)\b/;
const PLACEHOLDER = /lorem ipsum|\bTODO\b|\bTBD\b|\bFIXME\b|\bplaceholder\b|\bXXX\b|your app (name|description) here|coming soon|First paragraph:|Short hook under the name|One or two sentences you can change|İsmin altındaki kısa kanca|Yeni sürüm göndermeden istediğin zaman|\bExample (Game|App|Pro|Studio)\b/i; // Developer markers count only in capitals ("TODO:", "FIXME"): "todo" is a real word and keyword (a to-do app).
const PLACEHOLDER_MARKERS = /\bTODO\b|\bTBD\b|\bFIXME\b|\bXXX\b/;
const PLACEHOLDER_TEXT = /lorem ipsum|\bplaceholder\b|your app (name|description) here|coming soon|First paragraph:|Short hook under the name|One or two sentences you can change|İsmin altındaki kısa kanca|Yeni sürüm göndermeden istediğin zaman|\bExample (Game|App|Pro|Studio)\b/i;
const PLACEHOLDER = { test: (l: string) => PLACEHOLDER_MARKERS.test(l) || PLACEHOLDER_TEXT.test(l) } as RegExp;
const FGS_PERMISSION: Record<string, string> = { const FGS_PERMISSION: Record<string, string> = {
camera: 'CAMERA', connectedDevice: 'CONNECTED_DEVICE', dataSync: 'DATA_SYNC', health: 'HEALTH', location: 'LOCATION', mediaPlayback: 'MEDIA_PLAYBACK', camera: 'CAMERA', connectedDevice: 'CONNECTED_DEVICE', dataSync: 'DATA_SYNC', health: 'HEALTH', location: 'LOCATION', mediaPlayback: 'MEDIA_PLAYBACK',
mediaProjection: 'MEDIA_PROJECTION', microphone: 'MICROPHONE', phoneCall: 'PHONE_CALL', remoteMessaging: 'REMOTE_MESSAGING', specialUse: 'SPECIAL_USE', mediaProjection: 'MEDIA_PROJECTION', microphone: 'MICROPHONE', phoneCall: 'PHONE_CALL', remoteMessaging: 'REMOTE_MESSAGING', specialUse: 'SPECIAL_USE',

View file

@ -1,7 +1,11 @@
// storebound console fill: pure answer building (rule 5: only what the config proves is certain), the click gate, the // storebound console fill: pure answer building (rule 5: only what the config proves is certain), the click gate, the
// sign-in detector, and the engine run headless against MODELED console pages (tests/fixtures/console, written from // sign-in detector, and the engine run headless against MODELED console pages (tests/fixtures/console, written from
// the public help pages, not recorded) served on 127.0.0.1. No network. Browser tests skip when no Chromium launches. // the public help pages, not recorded) served on 127.0.0.1. No network. Browser tests skip when no Chromium is
import { afterAll, beforeAll, describe, expect, test } from 'bun:test'; // installed (a launch that times out fails instead). Load-proofing (tests/helpers/browser.ts): one launch with a long
// launch timeout, every context closed right after its test, event-driven waits for log lines, explicit test timeouts.
// Slow on purpose (marked SLOW): the sign-in / watching tests and the account tests wait out real "not here" timeouts
// of the engine (navTimeoutMs / navMs, scaled down through the options) and the profile tests relaunch Chromium.
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'bun:test';
import { mkdtempSync, rmSync } from 'node:fs'; import { mkdtempSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os'; import { tmpdir } from 'node:os';
import { join } from 'node:path'; import { join } from 'node:path';
@ -12,6 +16,7 @@ import { parseArgs } from '../cli/lib/args';
import { type ShipConfig, validateExtras } from '../cli/lib/config'; import { type ShipConfig, validateExtras } from '../cli/lib/config';
import { AGE_RATING_API, consoleAnswers, consoleResult, fillValue, FORM_IDS, type FormId, formMeta } from '../cli/lib/console-answers'; import { AGE_RATING_API, consoleAnswers, consoleResult, fillValue, FORM_IDS, type FormId, formMeta } from '../cli/lib/console-answers';
import { consoleReached, formDef, FORM_OPENERS, forbiddenControl, hasToken, isSignInText, isSignInUrl, navAllowed, navPlan, playDeveloperId, switchAllowed } from '../cli/lib/console-forms'; import { consoleReached, formDef, FORM_OPENERS, forbiddenControl, hasToken, isSignInText, isSignInUrl, navAllowed, navPlan, playDeveloperId, switchAllowed } from '../cli/lib/console-forms';
import { AFTER_ALL_MS, AFTER_EACH_MS, capped, CLOSE_TIMEOUT_MS, LAUNCH_TIMEOUT_MS, launchTestBrowser, logLines, testScope } from './helpers/browser';
const config: ShipConfig = { const config: ShipConfig = {
app: { name: 'Example Game', profile: 'game', privacyPolicyUrl: 'https://example.com/privacy', supportUrl: 'https://example.com/support', website: 'https://example.com', contactEmail: 'support@example.com' }, app: { name: 'Example Game', profile: 'game', privacyPolicyUrl: 'https://example.com/privacy', supportUrl: 'https://example.com/support', website: 'https://example.com', contactEmail: 'support@example.com' },
@ -160,14 +165,18 @@ describe('--dry --json', () => {
// ---- the engine against the modeled pages ---- // ---- the engine against the modeled pages ----
// eslint-disable-next-line @typescript-eslint/no-explicit-any // launched once for the whole file (module level: bun's hook timeouts do not apply, LAUNCH_TIMEOUT_MS does)
let browser: any = null; const shared = await launchTestBrowser('playwright');
let skipWhy = ''; const { browser, skipWhy } = shared;
try { if (!browser) console.warn(`console-fill browser tests skipped: no Chromium installed (${skipWhy}). Run \`bunx playwright install chromium\`.`);
const { chromium } = await import('playwright'); /** The contexts and engine runs of the current test, closed / awaited right after it (afterEach below). */
try { browser = await chromium.launch({ headless: true }); } catch { browser = await chromium.launch({ headless: true, channel: 'chrome' }); } const scope = testScope(() => browser);
} catch (e) { skipWhy = (e as Error).message.split('\n')[0]!; } /** Browser tests: a few seconds each on an idle machine; the timeout leaves room for a loaded one. */
if (!browser) console.warn(`console-fill browser tests skipped: no Chromium could launch (${skipWhy}). Run \`bunx playwright install chromium\`.`); const BROWSER_TEST_MS = 30_000;
/** SLOW tests (engine "not here" timeouts, Chromium relaunches): ~5-10 s idle. */
const SLOW_TEST_MS = 90_000;
/** Engine waits that are expected to SUCCEED: they return as soon as the element is there, so a long cap costs nothing. */
const FOUND_MS = 15_000;
const FIX = join(import.meta.dir, 'fixtures', 'console'); const FIX = join(import.meta.dir, 'fixtures', 'console');
/** Console URLs of the navigation plans -> modeled pages (bases: asc = <base>asc, play = <base>play). */ /** Console URLs of the navigation plans -> modeled pages (bases: asc = <base>asc, play = <base>play). */
@ -191,10 +200,12 @@ beforeAll(() => {
} }); } });
base = `http://127.0.0.1:${server.port}/`; base = `http://127.0.0.1:${server.port}/`;
}); });
afterAll(async () => { server?.stop(true); await browser?.close(); }, 30_000); // closing every context of the run can take a few seconds // bounded: every context is closed per test (afterEach) and each close is capped (tests/helpers/browser.ts)
afterEach(() => scope.settle(), AFTER_EACH_MS);
afterAll(async () => { await shared.close(); server?.stop(true); }, AFTER_ALL_MS);
async function open(file: string) { async function open(file: string) {
const page = await browser.newPage(); const page = await scope.newPage();
await page.goto(base + file); await page.goto(base + file);
return page; return page;
} }
@ -223,7 +234,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
// the next poll finds nothing left to do // the next poll finds nothing left to do
expect((await fillPage(page, def, pageAnswers('apple-app-record'), new Set([0]))).section).toBeNull(); expect((await fillPage(page, def, pageAnswers('apple-app-record'), new Set([0]))).section).toBeNull();
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('User Access under a plain heading (real App Store Connect): the radios are found in the dialog', async () => { test('User Access under a plain heading (real App Store Connect): the radios are found in the dialog', async () => {
const page = await open('apple-app-record-heading.html'); const page = await open('apple-app-record-heading.html');
@ -233,7 +244,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(s.filled).toContain('name'); expect(s.filled).toContain('name');
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('a lasting partial miss fills every field that was found and leaves only the missing one', async () => { test('a lasting partial miss fills every field that was found and leaves only the missing one', async () => {
const page = await open('apple-app-record-renamed.html'); const page = await open('apple-app-record-renamed.html');
@ -246,7 +257,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(await checked(page, 'iOS')).toBe(true); expect(await checked(page, 'iOS')).toBe(true);
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('a renamed label stops filling and falls back to guidance', async () => { test('a renamed label stops filling and falls back to guidance', async () => {
const page = await open('apple-app-record-renamed.html'); const page = await open('apple-app-record-renamed.html');
@ -258,7 +269,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
expect(consoleResult('apple-app-record', config).guidance).toContain('Name: Example Game'); expect(consoleResult('apple-app-record', config).guidance).toContain('Name: Example Game');
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('app privacy: section by section as the owner moves on; Next / Save / Publish never clicked', async () => { test('app privacy: section by section as the owner moves on; Next / Save / Publish never clicked', async () => {
const page = await open('apple-app-privacy.html'); const page = await open('apple-app-privacy.html');
@ -291,7 +302,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(done.size).toBe(def.sections.length); expect(done.size).toBe(def.sections.length);
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('content rating: full email in the page, Game, purchases yes, the rest empty + highlighted', async () => { test('content rating: full email in the page, Game, purchases yes, the rest empty + highlighted', async () => {
const page = await open('play-content-rating.html'); const page = await open('play-content-rating.html');
@ -312,7 +323,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(await page.getByRole('radiogroup', { name: /loot boxes/ }).getByRole('radio').evaluateAll((els: HTMLInputElement[]) => els.some(e => e.checked))).toBe(false); expect(await page.getByRole('radiogroup', { name: /loot boxes/ }).getByRole('radio').evaluateAll((els: HTMLInputElement[]) => els.some(e => e.checked))).toBe(false);
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('target audience: ages, appeal highlighted, ads yes', async () => { test('target audience: ages, appeal highlighted, ads yes', async () => {
const page = await open('play-target-audience.html'); const page = await open('play-target-audience.html');
@ -329,7 +340,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(await checked(page, /^Yes, my app contains ads/, 'radio')).toBe(true); expect(await checked(page, /^Yes, my app contains ads/, 'radio')).toBe(true);
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('sign-in detector and safeClick', async () => { test('sign-in detector and safeClick', async () => {
const signin = await open('signin.html'); const signin = await open('signin.html');
@ -344,7 +355,7 @@ describe.skipIf(!browser)('engine (headless, modeled pages)', () => {
expect(await safeClick(page.getByRole('button', { name: 'Cancel' }), 'Cancel')).toBe(true); expect(await safeClick(page.getByRole('button', { name: 'Cancel' }), 'Cancel')).toBe(true);
expect(await clicks(page)).toEqual(['Cancel']); expect(await clicks(page)).toEqual(['Cancel']);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
}); });
// ---- navigation to the form after sign-in ---- // ---- navigation to the form after sign-in ----
@ -394,10 +405,10 @@ describe('navigation plan (pure)', () => {
}); });
describe.skipIf(!browser)('navigation (headless, modeled pages)', () => { describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
const quiet = { timeoutMs: 1500, say: () => {} }; const quiet = { timeoutMs: FOUND_MS, say: () => {} }; // every navigation with `quiet` is expected to succeed
const navClicks = (page: any): Promise<string[]> => page.evaluate(() => (window as any).__navClicks()); const navClicks = (page: any): Promise<string[]> => page.evaluate(() => (window as any).__navClicks());
const noneDenied = (names: string[]) => { for (const n of names) expect(navAllowed(n, 'link')).toBe(true); }; const noneDenied = (names: string[]) => { for (const n of names) expect(navAllowed(n, 'link')).toBe(true); };
const fresh = async () => { const p = await browser.newPage(); await p.goto(base + 'blank.html'); await p.evaluate(() => sessionStorage.clear()); return p; }; const fresh = async () => { const p = await scope.newPage(); await p.goto(base + 'blank.html'); await p.evaluate(() => sessionStorage.clear()); return p; };
test('App Store Connect (EN): + > New App opens the dialog and it is filled; Create and Submit for Review never clicked', async () => { test('App Store Connect (EN): + > New App opens the dialog and it is filled; Create and Submit for Review never clicked', async () => {
const page = await fresh(); const page = await fresh();
@ -409,7 +420,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(s.filled).toContain('name'); expect(s.filled).toContain('name');
expect(await clicks(page)).toEqual(['+']); // the + button only, never Create / Submit for Review expect(await clicks(page)).toEqual(['+']); // the + button only, never Create / Submit for Review
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('App Store Connect (TR): Uygulama Ekle > Yeni Uygulama; Oluştur and İncelemeye Gönder never clicked', async () => { test('App Store Connect (TR): Uygulama Ekle > Yeni Uygulama; Oluştur and İncelemeye Gönder never clicked', async () => {
const page = await fresh(); const page = await fresh();
@ -418,7 +429,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(await navClicks(page)).toEqual(['Uygulama Ekle', 'Yeni Uygulama']); expect(await navClicks(page)).toEqual(['Uygulama Ekle', 'Yeni Uygulama']);
expect(await clicks(page)).toEqual(['+']); expect(await clicks(page)).toEqual(['+']);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('a missing step stops navigation, names the step and clicks nothing', async () => { test('a missing step stops navigation, names the step and clicks nothing', async () => {
const page = await fresh(); const page = await fresh();
@ -429,7 +440,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(await navClicks(page)).toEqual([]); expect(await navClicks(page)).toEqual([]);
expect(formMeta('apple-app-record', config).open[0]).toContain('New App'); expect(formMeta('apple-app-record', config).open[0]).toContain('New App');
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('App Privacy: appId deep link, or app list > the app > App Privacy; two apps of one name -> stop and list', async () => { test('App Privacy: appId deep link, or app list > the app > App Privacy; two apps of one name -> stop and list', async () => {
let page = await fresh(); let page = await fresh();
@ -447,7 +458,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(r).toMatchObject({ ok: false, failed: 'the app in the list', candidates: ['Example Game', 'Example Game'] }); expect(r).toMatchObject({ ok: false, failed: 'the app in the list', candidates: ['Example Game', 'Example Game'] });
expect(await navClicks(page)).toEqual([]); expect(await navClicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('Play: the app by package name > Policy and programs > App content > Start / Manage; nothing deny-listed clicked', async () => { test('Play: the app by package name > Policy and programs > App content > Start / Manage; nothing deny-listed clicked', async () => {
for (const [form, link, heading] of [['play-content-rating', 'Start', 'Content rating'], ['play-target-audience', 'Manage', 'Target audience and content']] as const) { for (const [form, link, heading] of [['play-content-rating', 'Start', 'Content rating'], ['play-target-audience', 'Manage', 'Target audience and content']] as const) {
@ -460,7 +471,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(await page.getByRole('heading', { level: 1 }).textContent()).toBe(heading); expect(await page.getByRole('heading', { level: 1 }).textContent()).toBe(heading);
await page.close(); await page.close();
} }
}); }, BROWSER_TEST_MS);
test('navClick refuses a Start button, Start rollout, Save and Publish even when pointed at them', async () => { test('navClick refuses a Start button, Start rollout, Save and Publish even when pointed at them', async () => {
const page = await open('play-app-content.html'); const page = await open('play-app-content.html');
@ -472,7 +483,7 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect((await navClick(page.getByRole('button', { name: 'Publish' }))).clicked).toBe(false); expect((await navClick(page.getByRole('button', { name: 'Publish' }))).clicked).toBe(false);
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
test('already on the form: nothing is clicked', async () => { test('already on the form: nothing is clicked', async () => {
const page = await open('play-content-rating.html'); const page = await open('play-content-rating.html');
@ -480,14 +491,14 @@ describe.skipIf(!browser)('navigation (headless, modeled pages)', () => {
expect(r).toMatchObject({ ok: true, steps: ['already open'] }); expect(r).toMatchObject({ ok: true, steps: ['already open'] });
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
}); });
// ---- sign-in during navigation, watching after the fallback, the session kept across relaunches ---- // ---- sign-in during navigation, watching after the fallback, the session kept across relaunches ----
/** A browser context whose console hosts (appstoreconnect / idmsa / play.google.com) are served from the fixtures. */ /** A browser context whose console hosts (appstoreconnect / idmsa / play.google.com) are served from the fixtures. */
async function consoleBrowser(map: (u: URL, cookie: string) => string | null): Promise<ConsoleBrowser> { async function consoleBrowser(map: (u: URL, cookie: string) => string | null): Promise<ConsoleBrowser> {
const ctx = await browser.newContext(); const ctx = scope.track(await browser.newContext());
await ctx.route(/^https?:\/\/(?!127\.0\.0\.1)/, async (route: any) => { await ctx.route(/^https?:\/\/(?!127\.0\.0\.1)/, async (route: any) => {
const u = new URL(route.request().url()); const u = new URL(route.request().url());
const cookie: string = (await route.request().headerValue('cookie')) ?? ''; const cookie: string = (await route.request().headerValue('cookie')) ?? '';
@ -500,22 +511,25 @@ async function consoleBrowser(map: (u: URL, cookie: string) => string | null): P
const done = new Promise<void>(r => ctx.on('close', () => { closed = true; r(); })); const done = new Promise<void>(r => ctx.on('close', () => { closed = true; r(); }));
return { mode: 'profile', context: ctx, page, pages: () => ctx.pages(), closed: done, isClosed: () => closed, close: () => ctx.close(), cleanup: () => {} }; return { mode: 'profile', context: ctx, page, pages: () => ctx.pages(), closed: done, isClosed: () => closed, close: () => ctx.close(), cleanup: () => {} };
} }
const until = async (what: string, fn: () => boolean | Promise<boolean>, ms = 20_000, said?: string[]) => { const tmpDirs: string[] = [];
const end = Date.now() + ms; afterAll(() => { for (const d of tmpDirs) rmSync(d, { recursive: true, force: true }); });
while (Date.now() < end) { if (await fn()) return; await Bun.sleep(50); } const tmpAccounts = () => { const d = mkdtempSync(join(tmpdir(), 'storebound-accounts-')); tmpDirs.push(d); return join(d, 'console-accounts.json'); };
throw new Error(`timed out waiting for: ${what}${said ? `\n${said.join("\n")}` : ""}`); /**
}; * The engine's timings scaled down for tests (production: tick 1 s, 20 s per navigation step, 10 min for a sign-in).
const tmpAccounts = () => join(mkdtempSync(join(tmpdir(), 'storebound-accounts-')), 'console-accounts.json'); * navTimeoutMs is both how long a step that IS there may take to show up (headroom for a loaded machine) and what a
const fast = (said: string[]) => ({ say: (m: string) => { said.push(m); }, tickMs: 100, navTimeoutMs: 1500, signInWaitMs: 30_000, accountsFile: tmpAccounts(), env: {} }); * step that is NOT there costs (the watching tests wait that out once), so it stays a few seconds, not FOUND_MS.
*/
const fast = (log: ReturnType<typeof logLines>) => ({ say: log.say, tickMs: 100, navTimeoutMs: 5000, signInWaitMs: 30_000, accountsFile: tmpAccounts(), env: {} });
const FILLED = (lines: string[]) => lines.some(m => /^New App: filled \d+/.test(m));
describe.skipIf(!browser)('sign-in and watching (headless, modeled pages on the real console hosts, routed locally)', () => { describe.skipIf(!browser)('sign-in and watching (headless, modeled pages on the real console hosts, routed locally)', () => {
test('ASC /login with an idmsa frame and no password field: detected mid-navigation, never touched; after sign-in navigation restarts at step 1', async () => { test('ASC /login with an idmsa frame and no password field: detected mid-navigation, never touched; after sign-in navigation restarts at step 1', async () => {
const b = await consoleBrowser((u, cookie) => u.hostname === 'idmsa.apple.com' ? 'idmsa-signin.html' const b = await consoleBrowser((u, cookie) => u.hostname === 'idmsa.apple.com' ? 'idmsa-signin.html'
: u.hostname !== 'appstoreconnect.apple.com' ? null : u.hostname !== 'appstoreconnect.apple.com' ? null
: u.pathname === '/login' ? 'asc-login.html' : u.pathname === '/apps' ? (cookie.includes('myacinfo=') ? 'asc-apps.html' : 'asc-shell.html') : null); : u.pathname === '/login' ? 'asc-login.html' : u.pathname === '/apps' ? (cookie.includes('myacinfo=') ? 'asc-apps.html' : 'asc-shell.html') : null);
const said: string[] = []; const log = logLines(), said = log.lines;
const run = fillSession(b, { form: 'apple-app-record', config, ...fast(said) }); const run = scope.run(fillSession(b, { form: 'apple-app-record', config, ...fast(log) }));
await until('the sign-in hint', () => said.some(m => m.startsWith('sign in in the browser window'))); await log.wait('the sign-in hint', l => l.some(m => m.startsWith('sign in in the browser window')));
expect(said.some(m => /^a sign-in page appeared at step/.test(m))).toBe(true); // the shell looked signed in, then /login expect(said.some(m => /^a sign-in page appeared at step/.test(m))).toBe(true); // the shell looked signed in, then /login
expect(said.some(m => m.includes('Keep me signed in'))).toBe(true); expect(said.some(m => m.includes('Keep me signed in'))).toBe(true);
expect(new URL(b.page.url()).pathname).toBe('/login'); expect(new URL(b.page.url()).pathname).toBe('/login');
@ -524,40 +538,40 @@ describe.skipIf(!browser)('sign-in and watching (headless, modeled pages on the
expect(await frame.evaluate(() => (window as any).__clicks)).toEqual([]); // nothing clicked on the sign-in form expect(await frame.evaluate(() => (window as any).__clicks)).toEqual([]); // nothing clicked on the sign-in form
expect(await frame.locator('#acc').inputValue()).toBe(''); // nothing typed expect(await frame.locator('#acc').inputValue()).toBe(''); // nothing typed
await b.page.evaluate(() => (window as any).__signIn()); // the owner signs in await b.page.evaluate(() => (window as any).__signIn()); // the owner signs in
await until('the New App dialog filled', () => said.some(m => /^New App: filled \d+/.test(m)), 20_000, said); await log.wait('the New App dialog filled', FILLED);
expect(said).toContain('signed in: opening the form again from step 1'); expect(said).toContain('signed in: opening the form again from step 1');
expect(await b.page.getByRole('textbox', { name: 'Name', exact: true }).inputValue()).toBe('Example Game'); expect(await b.page.getByRole('textbox', { name: 'Name', exact: true }).inputValue()).toBe('Example Game');
expect(await clicks(b.page)).toEqual(['+']); // never Create / Submit for Review expect(await clicks(b.page)).toEqual(['+']); // never Create / Submit for Review
await b.context.close(); await b.context.close();
expect((await run).filled).toBeGreaterThan(0); expect((await run).filled).toBeGreaterThan(0);
}, 40_000); }, SLOW_TEST_MS);
test('after the printed steps storebound keeps watching: the owner opens Apps by hand, navigation resumes at step 2 and fills', async () => { test('after the printed steps storebound keeps watching: the owner opens Apps by hand, navigation resumes at step 2 and fills', async () => {
const b = await consoleBrowser(u => u.hostname === 'appstoreconnect.apple.com' && u.pathname === '/apps' ? (u.search.includes('owner') ? 'asc-apps.html' : 'asc-apps-noplus.html') : null); const b = await consoleBrowser(u => u.hostname === 'appstoreconnect.apple.com' && u.pathname === '/apps' ? (u.search.includes('owner') ? 'asc-apps.html' : 'asc-apps-noplus.html') : null);
const said: string[] = []; const log = logLines(), said = log.lines;
const run = fillSession(b, { form: 'apple-app-record', config, ...fast(said) }); const run = scope.run(fillSession(b, { form: 'apple-app-record', config, ...fast(log) }));
await until('the printed steps', () => said.some(m => m.startsWith('open the form: Apps'))); await log.wait('the printed steps', l => l.some(m => m.startsWith('open the form: Apps')));
expect(await clicks(b.page)).toEqual([]); expect(await clicks(b.page)).toEqual([]);
await b.page.evaluate(() => { location.href = '/apps?owner=1'; }); // the owner navigates await b.page.evaluate(() => { location.href = '/apps?owner=1'; }); // the owner navigates
await until('the New App dialog filled', () => said.some(m => /^New App: filled \d+/.test(m)), 20_000, said); await log.wait('the New App dialog filled', FILLED);
expect(said).toContain('the page changed: storebound opens the form from step 2/4'); expect(said).toContain('the page changed: storebound opens the form from step 2/4');
expect(await b.page.evaluate(() => (window as any).__navClicks())).toEqual(['Add Apps', 'New App']); expect(await b.page.evaluate(() => (window as any).__navClicks())).toEqual(['Add Apps', 'New App']);
expect(await clicks(b.page)).toEqual(['+']); expect(await clicks(b.page)).toEqual(['+']);
await b.context.close(); await b.context.close();
await run; await run;
}, 40_000); }, SLOW_TEST_MS);
test('after the printed steps: the owner opens the dialog by hand, storebound sees it and fills it', async () => { test('after the printed steps: the owner opens the dialog by hand, storebound sees it and fills it', async () => {
const b = await consoleBrowser(u => u.hostname === 'appstoreconnect.apple.com' && u.pathname === '/apps' ? (u.search.includes('dialog') ? 'apple-app-record.html' : 'asc-apps-noplus.html') : null); const b = await consoleBrowser(u => u.hostname === 'appstoreconnect.apple.com' && u.pathname === '/apps' ? (u.search.includes('dialog') ? 'apple-app-record.html' : 'asc-apps-noplus.html') : null);
const said: string[] = []; const log = logLines();
const run = fillSession(b, { form: 'apple-app-record', config, ...fast(said) }); const run = scope.run(fillSession(b, { form: 'apple-app-record', config, ...fast(log) }));
await until('the printed steps', () => said.some(m => m.startsWith('open the form: Apps'))); await log.wait('the printed steps', l => l.some(m => m.startsWith('open the form: Apps')));
await b.page.evaluate(() => { location.href = '/apps?dialog=1'; }); await b.page.evaluate(() => { location.href = '/apps?dialog=1'; });
await until('the New App dialog filled', () => said.some(m => /^New App: filled \d+/.test(m)), 20_000, said); await log.wait('the New App dialog filled', FILLED);
expect(await clicks(b.page)).toEqual([]); // not even + : the dialog was open expect(await clicks(b.page)).toEqual([]); // not even + : the dialog was open
await b.context.close(); await b.context.close();
await run; await run;
}, 40_000); }, SLOW_TEST_MS);
test('resumeAt: the furthest step visible now, never the initial page load', async () => { test('resumeAt: the furthest step visible now, never the initial page load', async () => {
const page = await open('asc-apps.html'); const page = await open('asc-apps.html');
@ -568,15 +582,17 @@ describe.skipIf(!browser)('sign-in and watching (headless, modeled pages on the
await page.goto(base + 'asc-apps-noplus.html'); await page.goto(base + 'asc-apps-noplus.html');
expect(await resumeAt(page, plan)).toBeNull(); expect(await resumeAt(page, plan)).toBeNull();
await page.close(); await page.close();
}); }, BROWSER_TEST_MS);
for (const store of ['apple', 'play'] as const) { for (const store of ['apple', 'play'] as const) {
test(`${store}: a session cookie survives closing and relaunching storebound's own profile`, async () => { test(`${store}: a session cookie survives closing and relaunching storebound's own profile`, async () => {
const dir = mkdtempSync(join(tmpdir(), `storebound-profile-${store}-`)); const dir = mkdtempSync(join(tmpdir(), `storebound-profile-${store}-`));
const root = join(import.meta.dir, '..'); const root = join(import.meta.dir, '..');
// its own Chromium (a persistent profile), launched twice: SLOW, and the launch timeout is raised like the shared one
const opts = { store, profileDir: dir, fresh: true, headless: true, say: () => {}, launchTimeoutMs: LAUNCH_TIMEOUT_MS };
let b: ConsoleBrowser | null = null;
try { try {
const opts = { store, profileDir: dir, fresh: true, headless: true, say: () => {} }; b = await openConsoleBrowser(root, opts);
let b = await openConsoleBrowser(root, opts);
await b.page.goto(base + 'session-set'); await b.page.goto(base + 'session-set');
await b.close(); // graceful: Chromium writes its cookie store await b.close(); // graceful: Chromium writes its cookie store
await b.closed; await b.closed;
@ -586,8 +602,12 @@ describe.skipIf(!browser)('sign-in and watching (headless, modeled pages on the
expect(await b.page.textContent('#c')).toBe('kept'); expect(await b.page.textContent('#c')).toBe('kept');
await b.close(); await b.close();
await b.closed; await b.closed;
} finally { rmSync(dir, { recursive: true, force: true }); } } finally {
}, 60_000); // a failed assertion must not leave this Chromium running into the next test
if (b && !b.isClosed()) await capped(b.context.close(), CLOSE_TIMEOUT_MS);
rmSync(dir, { recursive: true, force: true });
}
}, 2 * LAUNCH_TIMEOUT_MS + SLOW_TEST_MS); // two Chromium launches (each capped) plus the test itself
} }
}); });
@ -627,7 +647,7 @@ describe('accounts (pure)', () => {
describe.skipIf(!browser)('accounts (headless, modeled pages)', () => { describe.skipIf(!browser)('accounts (headless, modeled pages)', () => {
const navClicks = (page: any): Promise<string[]> => page.evaluate(() => (window as any).__navClicks()); const navClicks = (page: any): Promise<string[]> => page.evaluate(() => (window as any).__navClicks());
const fresh = async () => { const p = await browser.newPage(); await p.goto(base + 'blank.html'); await p.evaluate(() => sessionStorage.clear()); return p; }; const fresh = async () => { const p = await scope.newPage(); await p.goto(base + 'blank.html'); await p.evaluate(() => sessionStorage.clear()); return p; };
const DENIED = ['Sign Out', 'Edit Profile', 'Create', 'Submit for Review', 'Create app', 'Create developer account', 'Save', 'Publish']; const DENIED = ['Sign Out', 'Edit Profile', 'Create', 'Submit for Review', 'Create app', 'Create developer account', 'Save', 'Publish'];
test('App Store Connect, 3 teams, the bundle id in the 2nd: switched through the account menu, remembered, then picked first', async () => { test('App Store Connect, 3 teams, the bundle id in the 2nd: switched through the account menu, remembered, then picked first', async () => {
@ -655,7 +675,7 @@ describe.skipIf(!browser)('accounts (headless, modeled pages)', () => {
expect(said2).toContain('team 1/3: Example Games Ltd'); expect(said2).toContain('team 1/3: Example Games Ltd');
for (const n of DENIED) expect(await navClicks(page)).not.toContain(n); for (const n of DENIED) expect(await navClicks(page)).not.toContain(n);
await page.close(); await page.close();
}, 60_000); }, SLOW_TEST_MS);
test('Play, one login in 5 developer accounts, the app in the 4th: found by package name, remembered, then opened directly', async () => { test('Play, one login in 5 developer accounts, the app in the 4th: found by package name, remembered, then opened directly', async () => {
const file = tmpAccounts(), said: string[] = []; const file = tmpAccounts(), said: string[] = [];
@ -682,7 +702,7 @@ describe.skipIf(!browser)('accounts (headless, modeled pages)', () => {
expect((await openAcross(page, { form: 'play-target-audience', config, say: m => { said3.push(m); }, bases: pb, navMs: 1500, file: tmpAccounts(), env: { STOREBOUND_PLAY_DEVELOPER_ID: '4444' } })).nav.ok).toBe(true); expect((await openAcross(page, { form: 'play-target-audience', config, say: m => { said3.push(m); }, bases: pb, navMs: 1500, file: tmpAccounts(), env: { STOREBOUND_PLAY_DEVELOPER_ID: '4444' } })).nav.ok).toBe(true);
expect(said3.some(m => m.includes('developer accounts'))).toBe(false); expect(said3.some(m => m.includes('developer accounts'))).toBe(false);
await page.close(); await page.close();
}, 60_000); }, SLOW_TEST_MS);
test('Play: a package in none of the developer accounts is said plainly; nothing deny-listed clicked', async () => { test('Play: a package in none of the developer accounts is said plainly; nothing deny-listed clicked', async () => {
const page = await fresh(); const page = await fresh();
@ -693,5 +713,5 @@ describe.skipIf(!browser)('accounts (headless, modeled pages)', () => {
expect(await clicks(page)).toEqual([]); expect(await clicks(page)).toEqual([]);
for (const n of DENIED) expect(await navClicks(page)).not.toContain(n); for (const n of DENIED) expect(await navClicks(page)).not.toContain(n);
await page.close(); await page.close();
}, 60_000); }, SLOW_TEST_MS);
}); });

View file

@ -8,6 +8,7 @@ import { existsSync, mkdirSync, mkdtempSync, readdirSync, rmSync, writeFileSync
import { tmpdir } from 'node:os'; import { tmpdir } from 'node:os';
import { join } from 'node:path'; import { join } from 'node:path';
import { chromeDataDir, CONSOLE_HOSTS, cookieApplies, copySession, devToolsEndpoint, filterCookies, NEVER_COPY, openConsoleBrowser, pickProfile, sessionFiles } from '../cli/console/session'; import { chromeDataDir, CONSOLE_HOSTS, cookieApplies, copySession, devToolsEndpoint, filterCookies, NEVER_COPY, openConsoleBrowser, pickProfile, sessionFiles } from '../cli/console/session';
import { capped, CLOSE_TIMEOUT_MS, LAUNCH_TIMEOUT_MS } from './helpers/browser';
const scratch = mkdtempSync(join(tmpdir(), 'sb-session-test-')); const scratch = mkdtempSync(join(tmpdir(), 'sb-session-test-'));
afterAll(() => rmSync(scratch, { recursive: true, force: true })); afterAll(() => rmSync(scratch, { recursive: true, force: true }));
@ -138,15 +139,19 @@ describe.skipIf(!hasChrome)('copy mode with real Chrome (throwaway profile, loca
} }); } });
const site = `http://127.0.0.1:${server.port}`, other = `http://localhost:${server.port}`; const site = `http://127.0.0.1:${server.port}`, other = `http://localhost:${server.port}`;
const src = tmp('chrome-real'); const src = tmp('chrome-real');
// two real Chrome launches: SLOW; launch timeouts raised like the shared browser's (tests/helpers/browser.ts), and
// whatever is still open is closed in `finally`, so a failed assertion leaves no Chrome running
let seed: any = null, b: any = null;
try { try {
const opts = { channel: 'chrome', headless: true, ignoreDefaultArgs: ['--use-mock-keychain', '--password-store=basic'] }; const opts = { channel: 'chrome', headless: true, timeout: LAUNCH_TIMEOUT_MS, ignoreDefaultArgs: ['--use-mock-keychain', '--password-store=basic'] };
const seed = await chromium.launchPersistentContext(src, opts); seed = await chromium.launchPersistentContext(src, opts);
const p0 = seed.pages()[0] ?? await seed.newPage(); const p0 = seed.pages()[0] ?? await seed.newPage();
await p0.goto(`${site}/set`); await p0.goto(`${other}/set`); await p0.goto(`${site}/set`); await p0.goto(`${other}/set`);
await seed.close(); await seed.close();
seed = null;
const said: string[] = []; const said: string[] = [];
const b = await openConsoleBrowser(join(import.meta.dir, '..'), { b = await openConsoleBrowser(join(import.meta.dir, '..'), {
store: 'apple', profileDir: tmp('own-profile'), say: m => said.push(m), chromeDir: src, hosts: ['127.0.0.1'], headless: true, platform: 'darwin', store: 'apple', profileDir: tmp('own-profile'), say: m => said.push(m), chromeDir: src, hosts: ['127.0.0.1'], headless: true, platform: 'darwin', launchTimeoutMs: LAUNCH_TIMEOUT_MS,
}); });
expect(b.mode).toBe('copy'); expect(b.mode).toBe('copy');
expect(said.join('\n')).toContain('your Chrome sign-in'); expect(said.join('\n')).toContain('your Chrome sign-in');
@ -159,6 +164,10 @@ describe.skipIf(!hasChrome)('copy mode with real Chrome (throwaway profile, loca
await b.context.close(); await b.context.close();
await b.closed; await b.closed;
expect(existsSync(b.tempDir!)).toBe(false); expect(existsSync(b.tempDir!)).toBe(false);
} finally { server.stop(true); } } finally {
}, 60_000); if (seed) await capped(seed.close(), CLOSE_TIMEOUT_MS);
if (b && !b.isClosed()) { await capped(b.context.close(), CLOSE_TIMEOUT_MS); b.cleanup(); }
server.stop(true);
}
}, 2 * LAUNCH_TIMEOUT_MS); // bounded by the two launches; ~3 s on an idle machine
}); });

120
tests/helpers/browser.ts Normal file
View file

@ -0,0 +1,120 @@
// Shared plumbing of the headless browser tests (tests/console-fill.test.ts, tests/site-overflow.test.ts,
// tests/console-session.test.ts). They used to time out now and then, mostly when the machine was busy:
// - the afterAll browser close (30 s, "(unnamed)" hook timeout). Cause: Google Chrome (the fallback when
// playwright's own Chromium is not downloaded) often hangs in its own shutdown after loading http pages and only
// exits when its 10 s teardown watchdog fires ("Teardown watchdog expired" in DEBUG=pw:browser); under load that
// passed 30 s. Measured on an idle machine: 10-30 s per close. The shared browser is a throwaway profile with nothing
// to flush, so it is launched as a browser server and KILLED at the end (milliseconds), not closed gracefully
// - Chromium's 30 s default launch timeout: one launch per file now, with an explicit, generous launch timeout; a
// launch that times out fails the file instead of quietly skipping it (a skip under load would hide lost
// coverage); only a browser that is not installed skips
// - every context of the run left open until afterAll, and a failed test's contexts and engine loops running into
// the next test: every context a test opens is tracked and closed right after it (afterEach)
// - polling sleeps in the waits for log lines: event-driven now (resolved on each new line)
// Hook timeouts are bounded by the numbers below (each close is capped), never open-ended.
/* eslint-disable @typescript-eslint/no-explicit-any */
/** Launching Chromium: well above a cold start on a loaded machine (seconds), far below "hung". */
export const LAUNCH_TIMEOUT_MS = 60_000;
/** One context close, or an engine run ending after its window closed; longer is abandoned (and the browser killed). */
export const CLOSE_TIMEOUT_MS = 15_000;
/**
* Hook timeouts. afterEach: a test's contexts close in parallel, each capped at CLOSE_TIMEOUT_MS, then the engine runs
* it started, each capped at CLOSE_TIMEOUT_MS. afterAll: disconnect (capped) and kill the browser server.
*/
export const AFTER_EACH_MS = 2 * CLOSE_TIMEOUT_MS + 5_000;
export const AFTER_ALL_MS = CLOSE_TIMEOUT_MS + 5_000;
/** Waits for `p` (its error ignored) or `ms`, whichever is first: true when `p` settled in time. Never rejects. */
export async function capped(p: Promise<unknown>, ms: number): Promise<boolean> {
let t: ReturnType<typeof setTimeout> | undefined;
const ok = await Promise.race([p.then(() => true, () => true), new Promise<boolean>(r => { t = setTimeout(() => r(false), ms); })]);
clearTimeout(t);
return ok;
}
export interface TestBrowser {
/** A connected Playwright Browser, or null when no Chromium is installed (then the browser tests skip). */
browser: any;
skipWhy: string;
/** afterAll: disconnects and kills the browser process (a throwaway profile: nothing to flush). Fast and bounded. */
close: () => Promise<void>;
}
/**
* Launches headless Chromium once, as a browser server the tests connect to: playwright's own build, else Google Chrome
* (channel "chrome"). `browser` is null only when neither is installed; a launch that times out or crashes throws.
*/
export async function launchTestBrowser(pkg: 'playwright' | 'playwright-core'): Promise<TestBrowser> {
const none = (e: unknown): TestBrowser => ({ browser: null, skipWhy: firstLine(e), close: async () => {} });
let chromium: any;
try { chromium = (await import(pkg)).chromium; } catch (e) { return none(e); }
const opts = { headless: true, timeout: LAUNCH_TIMEOUT_MS };
let server: any;
try { server = await chromium.launchServer(opts); } catch (e) {
if (!notInstalled(e)) throw e;
try { server = await chromium.launchServer({ ...opts, channel: 'chrome' }); } catch (e2) {
if (!notInstalled(e2)) throw e2;
return none(e);
}
}
let browser: any;
try { browser = await chromium.connect(server.wsEndpoint(), { timeout: LAUNCH_TIMEOUT_MS }); } catch (e) { await server.kill(); throw e; }
return {
browser, skipWhy: '',
close: async () => {
await capped(browser.close(), CLOSE_TIMEOUT_MS); // a connected browser: closes its contexts and disconnects
await server.kill(); // SIGKILL, then playwright removes the temporary profile
},
};
}
const firstLine = (e: unknown) => (e as Error).message.split('\n')[0]!;
/** Playwright's "no such browser" errors (bundled build not downloaded, Chrome channel not installed). */
const notInstalled = (e: unknown) => /Executable doesn't exist|distribution '[^']+' is not found|Failed to launch .* because executable/i.test((e as Error).message);
/**
* The contexts and engine runs of the current test. `newPage` opens a page in a fresh context (as browser.newPage
* does) and tracks it; `track` adds one opened elsewhere; `settle` (afterEach) closes them all and waits for the runs.
*/
export function testScope(browser: () => any) {
const contexts = new Set<any>();
const runs = new Set<Promise<unknown>>();
return {
async newPage(opts?: Record<string, unknown>): Promise<any> {
const ctx = await browser().newContext(opts);
contexts.add(ctx);
return ctx.newPage();
},
track<T>(ctx: T): T { contexts.add(ctx); return ctx; },
/** An engine run (fillSession ...) that ends when its context closes. */
run<T>(p: Promise<T>): Promise<T> { runs.add(p); return p; },
async settle(): Promise<void> {
const cs = [...contexts], rs = [...runs];
contexts.clear(); runs.clear();
await Promise.all(cs.map(c => capped(c.close(), CLOSE_TIMEOUT_MS)));
await Promise.all(rs.map(r => capped(r, CLOSE_TIMEOUT_MS)));
},
};
}
/**
* The log lines of an engine run (`say`), with event-driven waits: `wait` resolves on the line that makes `pred`
* true (checked on every new line, no polling) and fails after `ms` with every line seen so far.
*/
export function logLines() {
const lines: string[] = [];
const waiters = new Set<() => void>();
return {
lines,
say: (m: string) => { lines.push(m); for (const w of [...waiters]) w(); },
wait(what: string, pred: (lines: string[]) => boolean, ms = 30_000): Promise<void> {
if (pred(lines)) return Promise.resolve();
return new Promise<void>((resolve, reject) => {
const check = () => { if (pred(lines)) { done(); resolve(); } };
const t = setTimeout(() => { done(); reject(new Error(`timed out after ${ms} ms waiting for: ${what}\n${lines.join('\n')}`)); }, ms);
const done = () => { clearTimeout(t); waiters.delete(check); };
waiters.add(check);
});
},
};
}

View file

@ -470,3 +470,10 @@ describe('integration', () => {
expect(JSON_TOOLS.has('scan')).toBe(true); expect(JSON_TOOLS.has('scan')).toBe(true);
}); });
}); });
test('placeholder text: "todo" as a word or keyword is fine, TODO / FIXME markers and lorem ipsum are not', async () => {
const r = await scanVariant('clean', { 'store/appstore.md': s => s.replace(/(### keywords\n+```\n)/, '$1todo,tasks,') });
expect(r.findings.filter(f => f.rule === 'placeholder-text')).toEqual([]);
const bad = await scanVariant('clean', { 'store/appstore.md': s => s.replace(/(### keywords\n+```\n)/, '$1TODO,') });
expect(bad.findings.some(f => f.rule === 'placeholder-text')).toBe(true);
});

View file

@ -1,29 +1,28 @@
// The site (site/index.html) never scrolls sideways: at every viewport width from 320 to 1440 px (10 px steps), in the // The site (site/index.html) never scrolls sideways: at every viewport width from 320 to 1440 px (10 px steps), in the
// light and the dark theme, document.documentElement.scrollWidth stays within innerWidth. On a failure it names the // light and the dark theme, document.documentElement.scrollWidth stays within innerWidth. On a failure it names the
// elements whose right edge passes the viewport outside any scroll container (pseudo-elements show as their owner). // elements whose right edge passes the viewport outside any scroll container (pseudo-elements show as their owner).
// Uses the bundled playwright-core with its Chromium (or Google Chrome); skips when neither can launch. // Uses the bundled playwright-core with its Chromium (or Google Chrome); skips when neither is installed (a launch that
import { afterAll, describe, expect, test } from 'bun:test'; // times out on a busy machine fails instead). One launch, the context closed right after each test, capped closes
// (tests/helpers/browser.ts). SLOW on purpose: 113 widths x 2 themes, each a resize and a layout read.
import { afterAll, afterEach, describe, expect, test } from 'bun:test';
import { join } from 'node:path'; import { join } from 'node:path';
import { AFTER_ALL_MS, AFTER_EACH_MS, launchTestBrowser, testScope } from './helpers/browser';
const page = 'file://' + join(import.meta.dir, '..', 'site', 'index.html'); const page = 'file://' + join(import.meta.dir, '..', 'site', 'index.html');
// eslint-disable-next-line @typescript-eslint/no-explicit-any const shared = await launchTestBrowser('playwright-core');
let browser: any = null; const { browser, skipWhy } = shared;
let skipWhy = ''; if (!browser) console.warn(`site overflow test skipped: no Chromium installed (${skipWhy}). Run \`bunx playwright install chromium\`.`);
try { const scope = testScope(() => browser);
const { chromium } = await import('playwright-core');
try { browser = await chromium.launch({ headless: true }); } catch { browser = await chromium.launch({ headless: true, channel: 'chrome' }); }
} catch (e) { skipWhy = (e as Error).message.split('\n')[0]!; }
if (!browser) console.warn(`site overflow test skipped: no Chromium could launch (${skipWhy}). Run \`bunx playwright install chromium\`.`);
// closing Chromium can take longer than the 5 s hook default on a busy machine // bounded: one context per test, each close capped (bun's 5 s default hook timeout was too tight for Chrome's slow shutdown)
afterAll(async () => { await browser?.close(); }, 60_000); afterEach(() => scope.settle(), AFTER_EACH_MS);
afterAll(() => shared.close(), AFTER_ALL_MS);
describe.skipIf(!browser)('site: no horizontal overflow', () => { describe.skipIf(!browser)('site: no horizontal overflow', () => {
for (const scheme of ['light', 'dark'] as const) { for (const scheme of ['light', 'dark'] as const) {
test(`320-1440 px, ${scheme}`, async () => { test(`320-1440 px, ${scheme}`, async () => {
const ctx = await browser.newContext({ colorScheme: scheme, viewport: { width: 1440, height: 900 } }); const p = await scope.newPage({ colorScheme: scheme, viewport: { width: 1440, height: 900 } });
const p = await ctx.newPage();
await p.goto(page, { waitUntil: 'load' }); await p.goto(page, { waitUntil: 'load' });
const bad: string[] = []; const bad: string[] = [];
for (let w = 320; w <= 1440; w += 10) { for (let w = 320; w <= 1440; w += 10) {
@ -45,7 +44,6 @@ describe.skipIf(!browser)('site: no horizontal overflow', () => {
}); });
if (r) bad.push(r); if (r) bad.push(r);
} }
await ctx.close();
expect(bad).toEqual([]); expect(bad).toEqual([]);
}, 120_000); }, 120_000);
} }