CRT/storebound
1
0
Fork 0
Code Issues Pull requests Releases 1 Packages 1 Activity Actions

play build: signing passwords only through the child environment, never argv

Browse source
This commit is contained in:
CRTkafa 2026-10-23 08:51:07 +08:00
parent 7960063e0e
commit e4ebbb825d
5 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/build-sign.test.ts
View file

@ -532,13 +532,16 @@ describe('signed AAB, masked signing, IPA version train, release notes', () => {
test('gradleArgs passes the injected signing properties, maskArgs hides the passwords', () => {
const argv = gradleArgs(t, { hasWrapper: true, signing: s }, 'linux');
expect(argv).toContain('-Pandroid.injected.signing.store.file=/k/upload.jks');
expect(argv).toContain('-Pandroid.injected.signing.store.password=pw-store');
expect(argv).toContain('-Pandroid.injected.signing.key.alias=upload');
expect(argv).toContain('-Pandroid.injected.signing.key.password=pw-key');
expect(argv.join(' ')).not.toContain('pw-store');
expect(argv.join(' ')).not.toContain('pw-key');
expect(argv.join(' ')).not.toContain('password');
const env = signingEnv(s);
expect(env['ORG_GRADLE_PROJECT_android.injected.signing.store.password']).toBe('pw-store');
expect(env['ORG_GRADLE_PROJECT_android.injected.signing.key.password']).toBe('pw-key');
const shown = maskArgs(argv).join(' ');
expect(shown).not.toContain('pw-store');
expect(shown).not.toContain('pw-key');
expect(shown).toContain('store.password=***');
expect(shown).toContain('key.alias=upload');
expect(gradleArgs(t, { hasWrapper: true }, 'linux').join(' ')).not.toContain('signing');
});